See details in #669 (comment)

Deserialize looks nearly identical to the implementation of FromStr. It'd be nicer to put the common part into a separate function and call it from both places. Maybe even impl<&...

Originally posted by @Kixunil in #718 (comment)

Originally posted by @Kixunil in #718 (comment)

List of Rust libraries and applications. An unofficial experimental opinionated alternative to crates.io

Get familiar with one of the CSS frameworks Make decision on which one to use by Wed

#33

Post-merge nit for a follow-up PR: s.starts_with(char::is_uppercase); Originally posted by @dr-orlovsky in #768 (comment) Note: there's a clippy lint for this.

#32 #39

#53 #54 #55

#32 #39

Currently, the ttn module uses hard-coded strings for configuration: // TODO: Replace with your own TTN identifiers const HOST: &str = "eu1.cloud.thethings.network"; const...

test 2

While it may be tempting to use custom serde errors it's better to use things like invalid_value or other methods. We should check existing impls and make sure the best possible method is u...

Not displaying the source and returning it from the source method is better for consumers as they may want to display error sources differently (line-by-line is a popular example, even Cargo does i...

The most important feature of Psbt's is that they have all the information to compute the sighash. Our new APIs for taproot_key_spend_signature_hash and taproot_script_spend_signature_hash ...

bitcoin 0.27.1 depends on bitcoin_hashes 0.10.0 and secp256k1 0.20.3 which depends on bitcoin_hashes 0.9.7 causing unavoidable duplication of bitcoin_hashes crate. Bumping secp256k1. This should ge...

This implementation is actually not correct, but was "good enough" just to get something in here. See here for details: https://github.com/esp-rs/esp-hal/blob/main/esp-hal-common/...

Write an example in the examples directory with the workflow from BIP174. See the valid example that starts from the line in the above link. The private keys in the tests below are derived from the...

Similar to #892, but that spends a taproot spend. This is more challenging because Taproot psbt involves encoding a TapTree that is non-trivial to understand/use. There is no spec to compare agains...